Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2][Hbase] implement hbase catalog #7516

Merged
merged 21 commits into from
Sep 9, 2024
Merged

[Feature][Connector-V2][Hbase] implement hbase catalog #7516

merged 21 commits into from
Sep 9, 2024

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Local And e2e

Check list

@Hisoka-X
Copy link
Member

waiting #7169 be merged.

@Hisoka-X
Copy link
Member

Please resolve conflicts.

@github-actions github-actions bot added document dependencies Pull requests that update a dependency file CI&CD core SeaTunnel core module Spark flink Zeta transform-v2 Zeta Rest API format and removed hbase labels Sep 6, 2024
@github-actions github-actions bot added the api label Sep 6, 2024
@zhangshenghang
Revert "init"
c7fd0e5 
This reverts commit 8b4b926.
@zhangshenghang
Revert "init"
a5c6d89 
This reverts commit c7b6063.
@zhangshenghang
Revert "init"
9a044a7 
This reverts commit 65e75c4.
@github-actions github-actions bot added hbase and removed document dependencies Pull requests that update a dependency file CI&CD core SeaTunnel core module flink Zeta transform-v2 Zeta Rest API format api labels Sep 6, 2024
@github-actions github-actions bot removed the document label Sep 6, 2024
Hisoka-X
Hisoka-X reviewed Sep 7, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. I found a minior problem.

...base/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/catalog/HbaseCatalog.java Outdated Show resolved Hide resolved
Hisoka-X
Hisoka-X approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zhangshenghang !

@hailin0 hailin0 merged commit b978792 into apache:dev Sep 9, 2024
6 checks passed
@zhangshenghang zhangshenghang deleted the feature-implement-hbase-catalog branch September 10, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 e2e hbase reviewed Spark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Hbase] Implement Hbase connector catalog and typeconverter
3 participants
@zhangshenghang @Hisoka-X @hailin0